- Do any leftover iP tasks from the previous week
- Create a PR to the upstream repo
- Add Increments as branches:
Level-7
,Level-8
- Add Increments:
A-MoreOOP
,A-Packages
,A-Gradle
,A-JUnit
,A-Jar
- Add Increments as parallel branches:
A-JavaDoc
,A-CodingStandard
,Level-9
- [Optional] Get a head start on JavaFX
You are required to follow the Git standard from this week, as specified in this page.
Only future commits need to follow the Git standard. Editing past commit messages (to make them comply with the Git standard) is discouraged as it changes the commit timestamp, which can alter your iP progress timeline (as seen by progress tracking scripts).
Reminder about the deadline for the weekly project tasks:
1 Do any leftover iP tasks from the previous week
- Remember to do any leftover increments from the past weeks before starting on the current week's increments. This guideline applies to future weeks too.
2 Create a PR to the upstream repo
- Create a pull request (PR) from your fork to the upstream repo. Note the following:
- Create the PR from the
master
branch of your fork to themaster
branch of the upstream repo (https://github.com/nus-cs2103-AY2425S1/ip) - Set the PR name as
[{Your full/partial name or your GitHub username}] iP
e.g.,[Richard Mathews Chee] iP
or[Rich ... hee] iP
or[TheRichMat] iP
Note that the PR name will be publicly visible.
You may leave the description as empty. - If you created the PR correctly, it should appear in the list of PRs here.
- Steps for creating a PR is given in this textbook topic (steps 5 onwards):
- Create the PR from the
The PR will update automatically to reflect your latest code every time you push code to your fork. As a result, it provides a convenient way for us to access the current state of all your iP code from one location.
3 Add Increments as branches: Level-7
, Level-8
If you are new to Git branching, before attempting this iP increment, first learn Git branching from this week's textbook topics. In particular, learn how to merge a branch without fast forwarding.
- Do Level 7 in a branch named
branch-Level-7
. Here are the steps:- Start a branch
branch-Level-7
. - Implement Level 7 while committing to that branch at appropriate points,
- Merge the branch back to the
master
branch (remember to create a merge commit i.e., no fast-forward). - Git tag the merge commit in the
master
branch as usual (i.e., add the tagLevel-7
). - Push the following three things to your fork:
(a) themaster
branch,
(b) thebranch-Level-7
branch,
(c) theLevel-7
tag.
Advanced git users: do not delete the branch after merging.
Only merged branches are detected by the script. After merging a branchb1
to themaster
branch, you need to push both themaster
and theb1
branches to the fork. Pushing themaster
branch does not automatically take theb1
branch along with it just because it is already merged to themaster
branch.
- Start a branch
- Do Level 8 similar to the above, using a branch
branch-Level-8
.
Guidance for the item(s) below:
As you know, one main goal of the iP is to prepare for you for the tP. The task below is heavy on the 'training for tP' aspect.
In previous iP increments, you learned:
- How to merge branches locally and push to your fork
- How to create PRs from the
master
branch to an upstream repo
In the following iP task you will learn how to do the following new things, which are relevant to the tP:
- How to merge branches remotely, and pull to your local repo
- How to create PRs from branches other than
master
- How to manage PRs that your repo receive
- How to work with parallel PRs
Due to the above learning goals, this iP task is a bit complicated. Pay attention and try to achieve all learning goals along the way.
- Note how to merge PRs:
- Practice using parallel git branches and PRs, as explained below:
First, do each increment as a parallel branch (follow the branch naming convention you followed earlier
branch-Level-8
etc.), but do not merge any.%%{init: { 'theme': 'default', 'gitGraph': {'mainBranchName': 'master'}} }%% gitGraph commit id: "m1" commit id: "m2" branch branch-A-Assertions checkout branch-A-Assertions commit id: "b1c1" checkout master branch branch-A-CodeQuality checkout branch-A-CodeQuality commit id: "b2c1" checkout master branch branch-A-Streams checkout branch-A-Streams commit id: "b3c1" commit id: "b3c2" checkout masterThen, push each branch to your fork, and create a PR within your fork (i.e., from the increment branch to the
master
branch). Be careful not to create a PR to the upstream repo. If you did create such a PR by mistake, no worries, just close it yourself.
When you are doing the next step, you can run into merge conflicts. In some cases, GitHub will give you a way to resolve those conflicts using the Web interface. While this approach may be good enough for simple merge conflicts, de-conflicting locally in the standard way is safer (e.g., you can run tests to confirm the updated code is correct) and more standard (it's a standard Git feature that you can use even when you are not using GitHub for your project).
- Now, merge one of the PRs and update the remaining PRs accordingly, as given below:
- Merge one of the PRs on GitHub. Remember to choose the
Create merge commit
option when merging. - The above step will cause the
master
branch of your local repo to fall behind that of your fork (). Therefore, you need to sync the localmaster
with the remotemaster
branch. One way to do that is to switch to the localmaster
branch and then pull the updatedmaster
branch from your fork e.g.,$ git checkout master $ git pull origin master
The diagram below shows the current situation, assuming you merged theA-Assertions
PR first.%%{init: { 'theme': 'default', 'gitGraph': {'mainBranchName': 'master'}} }%% gitGraph commit id: "m1" commit id: "m2" branch branch-A-Assertions checkout branch-A-Assertions commit id: "b1c1" checkout master branch branch-A-CodeQuality checkout branch-A-CodeQuality commit id: "b2c1" checkout master branch branch-A-Streams checkout branch-A-Streams commit id: "b3c1" commit id: "b3c2" checkout master merge branch-A-Assertions tag: "A-Assertions"- Note how the remaining are no longer in sync with the latest
master
. To rectify, merge themaster
branch on to each of them. Resolve merge conflicts, if any. The outcome will be something like the below:
%%{init: { 'theme': 'default', 'gitGraph': {'mainBranchName': 'master'}} }%% gitGraph commit id: "m1" commit id: "m2" branch branch-A-Assertions checkout branch-A-Assertions commit id: "b1c1" checkout master branch branch-A-CodeQuality checkout branch-A-CodeQuality commit id: "b2c1" checkout master branch branch-A-Streams checkout branch-A-Streams commit id: "b3c1" commit id: "b3c2" checkout master merge branch-A-Assertions tag: "A-Assertions" checkout branch-A-CodeQuality merge master id: "merge master to ..." checkout branch-A-Streams merge master- Push the updated branches to your fork. The PRs will update automatically to reflect the updated branch.
- As before, tag the merge commit in the master branch and push the tag to your fork.
- Merge the remaining PRs using a procedure similar to the above. The diagram below shows the situation after merging the
A-CodeQuality
PR and syncing the localbranch-A-Streams
with the updatedmaster
branch.%%{init: { 'theme': 'default', 'gitGraph': {'mainBranchName': 'master'}} }%% gitGraph commit id: "m1" commit id: "m2" branch branch-A-Assertions checkout branch-A-Assertions commit id: "b1c1" checkout master branch branch-A-CodeQuality checkout branch-A-CodeQuality commit id: "b2c1" checkout master branch branch-A-Streams checkout branch-A-Streams commit id: "b3c1" commit id: "b3c2" checkout master merge branch-A-Assertions tag: "A-Assertions" checkout branch-A-CodeQuality merge master id: "merge master to ..." checkout branch-A-Streams merge master checkout master merge branch-A-CodeQuality tag: "A-CodeQuality" checkout branch-A-Streams merge master
4 Add Increments: A-MoreOOP
, A-Packages
, A-Gradle
, A-JUnit
, A-Jar
- While not required, you are encouraged to use separate branches for each increment.
Reason: that way, themaster
branch will always stay in a 'unbroken' state as the work-in-progress will be in a separate branch till such work is ready to be merged. - As before, commit, tag, and push, after each increment.
- Do the following increments in the given order because after doing
A-Gradle
you can use the Gradle option (rather than the IntelliJ option) when doingA-JUnit
andA-JAR
as they are easier to do using Gradle.
Note that if A-Jar
increment does not require any code changes, you may tag the commit at which this was achieved as A-Jar
(even if that commit has another tag already). Otherwise, tag the latest commit as usual. In both cases, push the tag to the fork.
5 Add Increments as parallel branches: A-JavaDoc
, A-CodingStandard
, Level-9
- Implement these three increments as three branches first (branch names:
branch-A-JavaDoc
,branch-A-CodingStandard
,branch-Level-9
), and then merge them one-by-one. Hopefully, you will encounter some merge conflicts so that you get to practice de-conflicting branches.
- The Java and Git standards to follow (for
A-CodingStandard
) are given in this page. - After finishing, assuming you encountered merge conflicts (and some were rather painful to resolve), think of how such conflicts could have been reduced (e.g., by changing the order of merging, or minimizing parallel branches when certain type of changes are being done to the code).
Relevant SE-EDU guide: Intellij IDEA: Configuring the code style
6 [Optional] Get a head start on JavaFX
If you can spare some time, start learning JavaFX by following the JavaFX tutorial @SE-EDU/guides. Doing so will make your life easier in the following week.